Skip to content
This repository has been archived by the owner on Feb 12, 2023. It is now read-only.

Update Universe emoji list #6230

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Conversation

skeletonium
Copy link

@skeletonium skeletonium commented Sep 4, 2020

I have updated the Universe emoji list, sourced from https://github.com/twitter/twemoji/tree/master/assets/svg, as well as the emoticons.xml file to add an appropriate method of input/shortcut for each emoji.

This would bring several benefits:

  • Adding a great amount of missing emojis, including many very commonly used ones such as 🤔.
  • Adding missing shortcuts for every emoji such as the one just mentioned (:thinking:).
  • Making the Universe emoji pack more visually appealing due to updated graphics.

No emojis were removed, only added. Compound emojis however weren't added (adding them all would bloat up the list anyway), nor any additional flags other than ones already present. For this reason some .svg files were replaced with the more specific version from the set.

However, there are two problems that will need to be resolved before the pull request is merged:

  • For some reason, the emojis don't display when they are posted, this is most likely somehow because the emoji set is larger, considering the problem is only present once the list of emojis exceeds 832 (the size of the original Universe set).
  • The row of buttons for going through pages of emojis becomes too long (see screenshots). I would suggest having two or multiple rows each with a maximum of about 12 buttons.

If needed, the following steps can be used to recreate the .svg file list after downloading https://github.com/twitter/twemoji/tree/master/assets/svg:
Replace some neutral emojis with specific ones:

cp 1f9b8-200d-2640-fe0f.svg 1f9b8.svg
cp 1f9d9-200d-2642-fe0f.svg 1f9d9.svg
cp 1f9da-200d-2640-fe0f.svg 1f9da.svg
cp 1f9db-200d-2642-fe0f.svg 1f9db.svg
cp 1f9dc-200d-2640-fe0f.svg 1f9dc.svg
cp 1f9dd-200d-2640-fe0f.svg 1f9dd.svg
cp 1f9de-200d-2642-fe0f.svg 1f9de.svg
cp 1f9df-200d-2642-fe0f.svg 1f9df.svg
cp 1f470-200d-2640-fe0f.svg 1f470.svg
cp 1f469-200d-2764-fe0f-200d-1f48b-200d-1f468.svg 1f48f.svg
cp 1f469-200d-2764-fe0f-200d-1f468.svg 1f491.svg
cp 1f468-200d-1f469-200d-1f466.svg 1f46a.svg

Create a file keeplist.txt from https://gist.github.com/skeletonium/7ec6d85ecf372cb4b63ee15a31ac9dfe and run following command:
ls -p | grep -v / | sed 's/\<keeplist.txt\>//g' | sort | comm -3 - <(sort keeplist.txt) | xargs rm

After removing keeplist.txt and renaming directory to Universe, sha256sum of the directory should be:
d1c67568e425c4eb653dec731373a6539e36a2a8907011d8af9abb26954666c4
Using command:
find Universe -type f -exec sha256sum {} \; | sort -k 2 | sha256sum

And with emoticons.xml, LICENSE, LICENSE-GRAPHICS, and README.md present, it should be
67c867bcadac32b67e5df0643f1fb890fd02774feedf8235c986f0f44d3ff2be

qToxEmojis1
qToxEmojis2
qToxEmojis3
qToxEmojis4
qToxEmojis5
qToxEmojis6
qToxEmojis7
qToxEmojis8
qToxEmojis9
qToxEmojis10
qToxEmojis11
qToxEmojis12
qToxEmojis13
qToxEmojis14
qToxEmojis15
qToxEmojis16
qToxEmojis17
qToxEmojis18
qToxEmojis19
qToxEmojis20
qToxEmojis21


This change is Reviewable

@skeletonium
Copy link
Author

I would like to squash all the "files uploaded" commits into a single one, as GitHub only let me upload 100 files at a time. I have read the contributing guidelines, sorry I don't know how to do that.

@sudden6
Copy link
Member

sudden6 commented Sep 6, 2020

Could it be that the reason some emoji are not shown is that you changed the <emoticon file="1f600"> to <emoticon file="1f600.svg">?

The thing with the dots is unfortunate, we really need a better emoji picker there :/

To squash the commits together you need git installed locally and then follow this comment: https://stackoverflow.com/a/5189600

If you need a GUI, I can recommend GitExtensions. Worst case I will squash the commits for you.

@skeletonium
Copy link
Author

skeletonium commented Sep 8, 2020

Could it be that the reason some emoji are not shown is that you changed the <emoticon file="1f600"> to <emoticon file="1f600.svg">?

I have tried removing all the .svg extensions from emoticons.xml and recompiling, it's still the same, this doesn't seem to be the issue. I have all but confirmed that it is somehow related to the number of emoticons/size of the emoticon list, because the problem only starts to be present once there are more than 832 emoticons, I have tried reducing the list to that number by removing a different portion of it each time. As long as there are 832 emoticons or less, they display correctly. Only once there are 833 or more, it stops working.

I can remove the .svg extensions if preferred but it doesn't seem it matters whether they are included or not.
I will squash my commits soon, most likely tomorrow.

skeletonium and others added 5 commits September 16, 2020 18:20
Add files via upload

Add files via upload

Add files via upload

Add files via upload

Add files via upload

Add files via upload

Add files via upload

Add files via upload

Add files via upload

Add files via upload

Add files via upload

Add files via upload

Add files via upload

Add files via upload

Add files via upload

Add files via upload
@skeletonium skeletonium marked this pull request as draft September 16, 2020 22:22
@skeletonium skeletonium marked this pull request as ready for review September 16, 2020 22:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants