-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust user agent version automatically #20864
Conversation
The version calculation is an estimation and it will drift off after some time. Hopefully the drift offset won't be noticeable within a few years. Also switched the user agent to Windows 10 which has the largest portion of users to avoid standing out from the crowd.
9c6576c
to
e72d516
Compare
You untie it from a specific browser version, but you bind it to a specific OS version (moreover, not the most recent), which is subject to the same obsolescence problem. Is this a good idea? |
Not many options available here IMO. Win11 market share is still relatively small compared to Win10. |
I would leave it as it is. "Linux x86_64" looks less affected by time. Besides, did we have any problems with it?.. |
No one reports it but it is too easy to identify/fingerprint an qbt user as the "Linux x86_64" user base is too damn small. |
If we proceed from the same considerations, Firefox userbase is also (relatively) small. |
I've considered using chrome user agent but its release schedule is too unpredictable and also the composition is too complex to get it right. |
Ok. |
The firefox release schedule looks to me that they release every 28 days (on average). The PR uses 30 days so it should slowly lag behind the latest release. Even if the calculation is slightly ahead of the release (which should be very rare) it is no big problem because it will be the same as Firefox Beta or Firefox Developer Edition (which still are valid user agents). Those FF betas uses +1 version from the released version. |
Just posting this as an FYI / post a question. Should we defer this PR & use Is this PR or the other user-agent PR going to be backported to 4.6.x branch? |
Probably not. The drift offset shouldn't be noticeable within a year or two. The maintenance sync/update could be performed once per 5, 6 years (if it really requires).
The other previous PR should be backported. This PR is suited for qbt v5 IMO. |
The version calculation is an estimation and it will drift off after some time. Hopefully the drift offset won't be noticeable within a few years.
Also switched the user agent to Windows 10 which has the largest portion of users to avoid standing out from the crowd.