fix: allow empty selector #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While unconventional, there may be no selector at all. In that case, the constraints will always be on (and can't be turned off). See the added test `no_selector` for an example. However, halo2-analyzer instead skips the constraints completely, causing a failure. This commit fixes the issue. Note that this commit only includes the fix for the under-constrained circuit analysis. Other types of analysis may still be incorrect, and require further fixes. The bug is originally discovered by @shankarapailoor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While unconventional, there may be no selector at all. In that case, the constraints will always be on (and can't be turned off). See the added test
no_selectorfor an example.However, halo2-analyzer instead skips the constraints completely, causing a failure. This commit fixes the issue.
Note that this commit only includes the fix for the under-constrained circuit analysis. Other types of analysis may still be incorrect, and require further fixes.
The bug is originally discovered by @shankarapailoor.