Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping: Remove all @author tags in javadoc #40702

Closed

Conversation

tamaro-skaljic
Copy link
Contributor

Because they don't adhere to the coding guidelines.

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/grpc gRPC area/hibernate-validator Hibernate Validator area/hibernate-orm Hibernate ORM area/infinispan Infinispan area/keycloak area/kubernetes area/maven area/mongodb area/narayana Transactions / Narayana area/oidc area/panache area/persistence area/platform Issues related to definition and interaction with Quarkus Platform area/resteasy area/resteasy-reactive area/security area/spring Issues relating to the Spring integration area/testing area/vertx labels May 17, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented May 17, 2024

/cc @gsmet (hibernate-orm), @yrodiere (hibernate-orm)

@yrodiere
Copy link
Member

yrodiere commented May 17, 2024

Well that's certainly bold. Policy or not, some people may take offense.
I'll let @gsmet / @maxandersen / @geoand comment on whether they want to do it.

Whether this happens or not, it would probably be a good idea to add build-time checks to forbid adding new @author tags, to conform with the policy that is supposed to "disallow" it. Checkstyle will allow something like that, probably other tools as well.

@geoand
Copy link
Contributor

geoand commented May 17, 2024

I think we don't need to remove the existing ones, just prevent new ones being added like @yrodiere says

@maxandersen
Copy link
Contributor

Only time I would consider this move would be if tooling wouldn't be able to deal with it easily.

If turns out tooling needs it we should ask the identified authors if ok to remove otherwise yeah it could be considered offensive.

@Sanne
Copy link
Member

Sanne commented May 20, 2024

This was proposed already in the past and the authors had objections so we decided to leave the original ones.

@Sanne Sanne closed this May 20, 2024
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/grpc gRPC area/hibernate-orm Hibernate ORM area/hibernate-validator Hibernate Validator area/infinispan Infinispan area/keycloak area/kubernetes area/maven area/mongodb area/narayana Transactions / Narayana area/oidc area/panache area/persistence area/platform Issues related to definition and interaction with Quarkus Platform area/resteasy area/resteasy-reactive area/security area/spring Issues relating to the Spring integration area/testing area/vertx triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants