Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load workspace modules in parallel #40712

Merged
merged 1 commit into from
May 19, 2024

Conversation

aloubyansky
Copy link
Member

This enhancement enables parallel loading of Maven workspace modules.

Below is a comparison of the current non-parallel loading to the new parallel loading based on running tests under https://github.com/quarkusio/quarkus/tree/main/integration-tests/virtual-http with mvn test.

Current:

LOADED 1272 modules in 153 ms, parallel=false
LOADED 1272 modules in 107 ms, parallel=false
LOADED 1272 modules in 74 ms, parallel=false
LOADED 1272 modules in 59 ms, parallel=false

New:

LOADED 1272 modules in 110 ms, parallel=true
LOADED 1272 modules in 34 ms, parallel=true
LOADED 1272 modules in 21 ms, parallel=true
LOADED 1272 modules in 17 ms, parallel=true

@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label May 18, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented May 18, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 11e1e86.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

@gsmet gsmet merged commit 3536fe9 into quarkusio:main May 19, 2024
51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone May 19, 2024
@gsmet
Copy link
Member

gsmet commented May 19, 2024

@aloubyansky looks a bit sensitive to be included post-CR1?

@aloubyansky
Copy link
Member Author

Yeah, no problem, it can wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants