fix(QScrollArea): correctly compute snap position for thumb #17206 #17207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI Tests Results 1 files 97 suites 37s ⏱️ Results for commit f764d29. ♻️ This comment has been updated with latest results. |
8 tasks
rstoenescu
requested changes
Jun 5, 2024
| const pos = offset - data.thumbSize.value / 2 | ||
| setScroll(pos / container[ axis ].value * data.size.value, axis) | ||
| const targetThumbStart = offset - data.thumbSize.value / 2 | ||
| const percentage = between(targetThumbStart / (props.container[ axis ].value - data.thumbSize.value), 0, 1) |
There was a problem hiding this comment.
Hi,
There is no container prop. Did you mean container instead of props.container?
There was a problem hiding this comment.
Hi. You are correct! I have taken this from another branch that has props.container. New commit pushed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17206
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
devbranch (orv[X]branch)fix: #xxx[,#xxx], where "xxx" is the issue number)