chore(core): add config hot-reload subsystem and implementation for pgwire credential changes #4168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sklarsa
changed the title
sklarsa
changed the title
…into steve/hot-reload
bluestreak01
reviewed
Jun 6, 2024
… missing to be done - behaviour when the file is deleted after server startup: Current logs: ``` Loading DEV CXX library: /io/questdb/bin-local/libquestdb.dylib Reading log configuration from /tmp/dbroot-fixes/conf/log.conf 2024-06-06T07:52:14.406089Z A server-main unknown [DEVELOPMENT]. Copyright (C) 2014-2024, all rights reserved. 2024-06-06T07:52:14.589491Z A server-main darwin-aarch64 [Vanilla,0, 64 bits, 8 processors] 2024-06-06T07:52:14.598472Z I server-main Web Console is up to date 2024-06-06T07:52:14.599733Z A server-main Server config: /tmp/dbroot-fixes/conf/server.conf Server configuration file does not exist! /tmp/dbroot-fixes/conf/server.conf ```
…into steve/hot-reload
… into steve/hot-reload
we do not disable hot-reload if it was started with hot-reload enabled
[PR Coverage check]😍 pass : 299 / 476 (62.82%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This swaps out PropServerConfiguration usage with ReloadingPropServerConfiguration. It should be a no-op, in preparation for hot-reloading config
Instead of inheriting from PropServerConfiguration, I decided to wrap it in a new class to avoid moving code around too much, since the validation logic is in the PropServerConfiguration constructor