[ci skip]Docs highlight form_with over form_for #51704
Open
+67
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
form_for, and form_tag, have been soft-deprecated in favour of form_with. However, the documentation outside of the Rails Guide does not show this change often missing form_with completely. This PR fixes that. Changes: - Adding form_with before form_for in text. - Replacing form_with with form_for in example code.
|
It looks like this covers some of the same content as #50744. Let me get that merged first and then we can rebase this one |
|
Thanks @skipkayhil ! Drat, should have checked! 🤦 I'll keep an eye out! |
|
Hello @skipkayhil (or other maintainers!) Everything is looking good, but one decision is required: The merged commit has removed all mention of Do you want form_for to remain in the documentation like this PR or do you want it removed completely like the merged commit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
form_forhas been soft-deprecated in favour ofform_with.However, the documentation outside of the Rails Guide does not show this change
and in the case of these changes it misses
form_withcompletely.Changes:
form_withbeforeform_forin documentation.form_withwithform_forin example code.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]