Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define column methods on the ColumnMethods module #51730

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Define column methods on the ColumnMethods module #51730

wants to merge 1 commit into from

Commits on May 3, 2024

  1. Define column methods on the ColumnMethods module 

    The way they were being defined inside the `included` hook meant
they ended up being defined directly on TableDefinition, contrary
to the documentation:
https://api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/PostgreSQL/ColumnMethods.html

I left `define_column_methods` as a class method that gets extended
onto TableDefinition, since there's at least one gem that relies
on being able to call it there to define their own column types
    @ccutrer
    ccutrer committed May 3, 2024
    Configuration menu
    Copy the full SHA
    710deb8 View commit details
    Browse the repository at this point in the history