New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid setting fixed app name in console prompt #51732
Merged
carlosantoniodasilva
merged 1 commit into
rails:main
from
Shopify:fix-rails-console-prompt
May 14, 2024
Merged
Avoid setting fixed app name in console prompt #51732
carlosantoniodasilva
merged 1 commit into
rails:main
from
Shopify:fix-rails-console-prompt
May 14, 2024
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
suggested changes
May 5, 2024
flavorjones
suggested changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can you squash these commits?
st0012
force-pushed
the
fix-rails-console-prompt
branch
from
May 6, 2024 17:11
6351533
to
a507f53
Compare
Instead, the app's name should be set via a separate IRB config, which will allow it to be changed at runtime. Co-authored-by: Mike Dalessio <mike.dalessio@gmail.com>
st0012
force-pushed
the
fix-rails-console-prompt
branch
from
May 6, 2024 23:02
a507f53
to
beba30b
Compare
flavorjones
approved these changes
May 8, 2024
carlosantoniodasilva
added a commit
that referenced
this pull request
May 14, 2024
Avoid setting fixed app name in console prompt
Test seems to be failing now because of this change |
carlosantoniodasilva
added a commit
that referenced
this pull request
May 14, 2024
We need to pass the verbose option in order to test the full expected output. Not sure why these were green on the branch. Introduced by #51732.
carlosantoniodasilva
added a commit
that referenced
this pull request
May 15, 2024
We need to pass the verbose option in order to test the full expected output. Not sure why these were green on the branch. Introduced by #51732.
Sorry for causing the failure. It's likely caused by the latest IRB release and was not caught here because the branch hadn't bumped its version yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
IRB allows changing its prompt's name during the session, like:
But because I previously set the app name as part of the prompt, instead of via the
irb_name
config, such change can't happen in a Rails console:This can be problematic as tools/features can rely on the name change to indicate state change (example).
Detail
Instead of setting app name as a fixed value in prompt, I replaced it with
%N
, which IRB uses to display theirb_name
attribute. And then we can set assign the app name toIRB.conf[:IRB_NAME]
(default is"irb"
).Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]