New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce compressor
option to ActiveRecord::Encryption::Encryptor
#51735
base: main
Are you sure you want to change the base?
Conversation
aeb3171
to
17ff722
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming of the custom compressor's methods seems inconsistent to me. Would you consider using Encryptor
's convention and name them compress/uncompress
instead of ZLib
's deflate/inflate
?
I also think this PR should update the Rails Guides page on encryption, guides/source/active_record_encryption.md
to explain how to implement a custom compressor.
17ff722
to
633cdc2
Compare
883a321
to
3231918
Compare
Hi, @flavorjones ! I changed signature of compressor ( |
a34e1dd
to
d2de562
Compare
CI failures seem unrelated, you might want to rebase just to be sure as I think most of those have been fixed |
3a52769
to
5664b8c
Compare
5664b8c
to
d0a8297
Compare
@zzak I just rebased it, and it looks like all CI failures are fixed now. 😄 |
Motivation / Background
There are more performant algorithms than
zlib
, likezstd
orsnappy
. So I made it possible to configure the compressor to take advantage of these more performant algorithms.Detail
Make
compressor
as argument which default value iszlib
.Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
Discussion
What do you thinks about make compressor as property of
ActiveRecord::Encryption
?