feat: Replace the parallel unit mapping with worker slot mapping in frontend. #16801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor fragment mappings and cleanup code Refactor worker_node, enhance vnode logic, update imports & mapping Refactor: Disable `FragmentParallelUnitMapping` in protobuf and Rust code Refactor/gen: Improve formatting in `risingwave_common` tests Removed proto comments; updated Rust imports and tests. Remove `FragmentParallelUnitMapping` import and extra lines in `observer_manager.rs` Refactor FragManager, cleanup proto fields & comments Remove commented-out alternative vnode placement code Refactor: Clean up imports in fragment and streaming_job Refactor worker mapping in join operation Refactor fields() output in db lib for brevity Refine comments on migration and worker ID terms
… & import management Signed-off-by: Shanicky Chen <peng@risingwave-labs.com>
Signed-off-by: Shanicky Chen <peng@risingwave-labs.com>
shanicky
force-pushed
the
peng/fe-remove-pu-slot
branch
from
8727943
to
40c8a7e
Compare
added 5 commits
May 17, 2024 14:35
shanicky
changed the title
5 tasks
added 5 commits
May 21, 2024 15:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR attempts to replace the fixed global ParallelUnitId with a dynamically generated WorkerSlotId. The WorkerSlotId is in the format of a u64, created by the expression
worker_id << 32 | slot_indexBecause we switched to u64, some runtime types need to be converted from u32 to u64.
The previous PR #16205 used WorkerMapping, which resulted in the loss of parallelism information on the worker, leading to many strange parallelism judgment issues and causing a decline in performance.
Checklist
./risedev check(or alias,./risedev c)