Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support authorization syntax for CREATE SCHEMA and omitted schema name #16806

Merged
merged 3 commits into from
May 20, 2024

Conversation

yezizp2012
Copy link
Contributor

@yezizp2012 yezizp2012 commented May 17, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Close #15680 .
Support syntax as follows:

CREATE SCHEMA [ IF NOT EXISTS ] schema_name [ AUTHORIZATION user_name ]
CREATE SCHEMA [ IF NOT EXISTS ] AUTHORIZATION user_name

Examples:

dev=> create schema if not exists authorization joe;
CREATE_SCHEMA
dev=> create schema if not exists new_schema authorization joe;
CREATE_SCHEMA
dev=> show schemas;
        Name
--------------------
 information_schema
 public
 pg_catalog
 joe
 new_schema
 rw_catalog
(6 rows)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Support syntax as follows:

CREATE SCHEMA [ IF NOT EXISTS ] schema_name [ AUTHORIZATION user_name ]
CREATE SCHEMA [ IF NOT EXISTS ] AUTHORIZATION user_name

If the schema name is omitted, the user_name is used as the schema name.

@yezizp2012 yezizp2012 added the user-facing-changes Contains changes that are visible to users label May 17, 2024
@yezizp2012 yezizp2012 added this pull request to the merge queue May 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2024
@yezizp2012 yezizp2012 enabled auto-merge May 20, 2024 05:32
@yezizp2012 yezizp2012 added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit 6d523e5 May 20, 2024
28 checks passed
@yezizp2012 yezizp2012 deleted the feat/schema-authorization branch May 20, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support CREATE SCHEMA schema_name AUTHORIZATION user_name;
2 participants