Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avm2: Implement TextField::GetRawText #15117

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

avm2: Implement TextField::GetRawText #15117

wants to merge 2 commits into from

Conversation

TFSMads
Copy link
Contributor

@TFSMads TFSMads commented Feb 4, 2024

No description provided.

@evilpie
Copy link
Collaborator

evilpie commented Feb 4, 2024 •
edited

Hi! Thank you for your contribution. It seems like this method is not documented and your current implementation is identical to the text getter. Did you investigate the difference between them? Could you provide a few tests for this? (I imagine especially around lines and text vs. HTML)

@Dinnerbone Dinnerbone added the waiting-on-author Waiting on the PR author to make the requested changes label Feb 7, 2024
@danielhjacobs danielhjacobs added the avm2 AVM2 (ActionScript 3.0) issues label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
avm2 AVM2 (ActionScript 3.0) issues waiting-on-author Waiting on the PR author to make the requested changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TFSMads @evilpie @Dinnerbone @danielhjacobs