Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Log support map on test startup #6638

Merged
merged 4 commits into from
May 21, 2024

Conversation

joeyparrish
Copy link
Member

When running tests with logging enabled, the logs will now always contain a full map of media features supported on this platform.

When running tests with logging enabled, the logs will now always contain a full map of media features supported on this platform.
@shaka-bot
Copy link
Collaborator

Incremental code coverage: No instrumented code was changed.

Copy link
Collaborator

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but evidently it is causing a test failure.
I wonder if something is being cached somewhere, such that calling probeSupport is messing up that player unit test? We've added a lot of caches for various browser API calls.

@joeyparrish
Copy link
Member Author

Yeah, I haven't been able to figure out the mechanism of this failure yet. This PR is not urgent, though. This debugging info wouldn't even show up in CI logs by default.

@avelad
Copy link
Collaborator

avelad commented May 21, 2024

I have found the error, I will push a commit to fix it. There is a failure in the test that had not been detected until now. ec-3 is not compatible with most browsers...

@avelad avelad added the component: tests The issue involves our automated tests (generally; otherwise use a more specific component) label May 21, 2024
@avelad avelad added this to the v4.9 milestone May 21, 2024
@avelad avelad merged commit 26c3f64 into shaka-project:main May 21, 2024
29 of 31 checks passed
@joeyparrish joeyparrish deleted the log-support branch May 22, 2024 16:16
joeyparrish added a commit that referenced this pull request May 31, 2024
When running tests with logging enabled, the logs will now always
contain a full map of media features supported on this platform.

---------

Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tests The issue involves our automated tests (generally; otherwise use a more specific component)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants