-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Log support map on test startup #6638
Conversation
When running tests with logging enabled, the logs will now always contain a full map of media features supported on this platform.
Incremental code coverage: No instrumented code was changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, but evidently it is causing a test failure.
I wonder if something is being cached somewhere, such that calling probeSupport is messing up that player unit test? We've added a lot of caches for various browser API calls.
Yeah, I haven't been able to figure out the mechanism of this failure yet. This PR is not urgent, though. This debugging info wouldn't even show up in CI logs by default. |
I have found the error, I will push a commit to fix it. There is a failure in the test that had not been detected until now. ec-3 is not compatible with most browsers... |
When running tests with logging enabled, the logs will now always contain a full map of media features supported on this platform. --------- Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
When running tests with logging enabled, the logs will now always contain a full map of media features supported on this platform.