Remove the last use of getPackageForFile on symbols #7758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jez
force-pushed
the
jez-no-packge-for-symbol
branch
from
d886edc
to
4b37b5c
Compare
jez
force-pushed
the
jez-no-packge-for-symbol
branch
from
4b37b5c
to
9170e00
Compare
jez
force-pushed
the
jez-no-packge-for-symbol
branch
from
9170e00
to
ccb77cb
Compare
jez
force-pushed
the
jez-no-packge-for-symbol
branch
from
ccb77cb
to
88433f1
Compare
jez
force-pushed
the
jez-pkg-root-symbol
branch
from
076ae81
to
f3a6fc5
Compare
jez
force-pushed
the
jez-no-packge-for-symbol
branch
from
88433f1
to
f04d1c6
Compare
jez
force-pushed
the
jez-pkg-root-symbol
branch
from
f3a6fc5
to
53effa0
Compare
jez
force-pushed
the
jez-no-packge-for-symbol
branch
from
f04d1c6
to
3b22c41
Compare
jez
force-pushed
the
jez-pkg-root-symbol
branch
from
53effa0
to
c28c87b
Compare
jez
force-pushed
the
jez-no-packge-for-symbol
branch
from
3b22c41
to
49c181f
Compare
This is the last place where we were using `sym.loc().file()` to get the package that owns the symbol, rather than using symbol information to lookup the package directly. There are still a handful of `getPackageNameForFile` calls (which get the `MangledName` for the package instead of the full `PackageInfo`), and removing all the rest of these should mean that we can remove the part of `VisibilityChecker` that calls `addLoc` to ensure that a symbol's canonical loc matches the owning package.
jez
force-pushed
the
jez-pkg-root-symbol
branch
from
c28c87b
to
41a7453
Compare
jez
force-pushed
the
jez-no-packge-for-symbol
branch
from
49c181f
to
4a10668
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is the last place where we were using
sym.loc().file()to get the package that owns the symbol, rather than using symbol information to lookup the package directly.There are still a handful of
getPackageNameForFilecalls (which get theMangledNamefor the package instead of the fullPackageInfo), and removing all the rest of these should mean that we can remove the part ofVisibilityCheckerthat callsaddLocto ensure that a symbol's canonical loc matches the owning package.Test plan
See included automated tests.