Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip #7762

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

wip #7762

wants to merge 8 commits into from

Conversation

fable-stripe
Copy link
Collaborator

Motivation

Test plan

See included automated tests.

@fable-stripe fable-stripe requested a review from a team as a code owner March 12, 2024 21:30
@fable-stripe fable-stripe requested review from jez and removed request for a team March 12, 2024 21:30
@fable-stripe
Copy link
Collaborator Author

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build results here:

https://go/builds/bui_Pj5OxcpRZPofnj
https://go/builds/bui_Pj5O1WoYjYzPQ9
https://go/builds/bui_Pj5O7gYSWiTqS3

@fable-stripe
Copy link
Collaborator Author

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build results here:

https://go/builds/bui_Pj5e6hVHieQm6W
https://go/builds/bui_Pj5esM9Ka6hBKD
https://go/builds/bui_Pj5eENhPPp7P5w

@fable-stripe
Copy link
Collaborator Author

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build results here:

https://go/builds/bui_Pj5pRCfYYIeMCu
https://go/builds/bui_Pj5pAvFdmE8nxL
https://go/builds/bui_Pj5pitniFLc1PQ

@fable-stripe
Copy link
Collaborator Author

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build results here:

https://go/builds/bui_Pj5zStCLCmztDI
https://go/builds/bui_Pj5zFESqVs2Nkc
https://go/builds/bui_Pj5zxQhXrFPlyo

@fable-stripe
Copy link
Collaborator Author

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build results here:

https://go/builds/bui_Pj697WC7VDSoDQ
https://go/builds/bui_Pj69dFyC6SkFo6
https://go/builds/bui_Pj699hkFyrTg4D

@fable-stripe
Copy link
Collaborator Author

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build results here:

https://go/builds/bui_Pj6LXLcjLoayNo
https://go/builds/bui_Pj6L7AP1OiXs0f
https://go/builds/bui_Pj6L5x1jIboEbl

@jez jez removed their request for review March 15, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant