Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement(CM): bulk delete and unpublish migration to v5 #20235

Merged
merged 33 commits into from May 9, 2024
Merged

enhancement(CM): bulk delete and unpublish migration to v5 #20235

merged 33 commits into from May 9, 2024

Conversation

madhurisandbhor
Copy link
Contributor

@madhurisandbhor madhurisandbhor commented Apr 30, 2024 •
edited

What does it do?

Migrating bulk delete and unpublish to V5

How to test it?

Bulk Delete and Bulk Unpublish are in action on V5, no V5 design changes are included.

Related issue(s)/PR(s)

⚠️ Merge after this related BE PR, #20184

madhurisandbhor and others added 19 commits April 4, 2024 12:35
@madhurisandbhor
fix: added bulk actions
7c70880
@Feranchz
chore: migrate bulk publish & unpublish to v5
a2e14b4
@Feranchz
chore: change findLocales type to accept arrays
5693666
@Feranchz
Merge branch 'v5/main' of github.com:strapi/strapi into v5/bulk-publi…
6357df1 
…sh-unpublish
@Feranchz
chore: fix lint error
df2d2f0
@Feranchz
Merge branch 'v5/main' of github.com:strapi/strapi into v5/bulk-publi…
a63f691 
…sh-unpublish
@Feranchz
chore: migrate bulkDelete to v5 (#20161)
b1574bc 
* chore: migrate bulkDelete to v5

* chore: change findLocales type to accept strings array

* fix: docs prettier styles

* chore: remove console.log
@madhurisandbhor
Merge branch 'v5/main' into fix/bulk-actions-migration
80dc8b8
@madhurisandbhor
Merge branch 'v5/bulk-publish-unpublish' into fix/bulk-actions-migration
d17b241
@Feranchz
enhancement: migrate countManyDraftRelations to v5
a50e1df
@Feranchz
Merge branch 'v5/bulk-publish-unpublish' of github.com:strapi/strapi …
a241141 
…into v5/bulk-publish-unpublish
@Feranchz
Merge branch 'v5/main' of github.com:strapi/strapi into v5/bulk-publi…
49a3dbb 
…sh-unpublish
@madhurisandbhor
feat: bulk delete with locale selection option
6dd70ca
@madhurisandbhor
fix: bulk unpublish working without locale support
f231f25
@madhurisandbhor
Merge branch 'v5/main' into fix/bulk-actions-migration
6ba5cee
@madhurisandbhor
test: e2e tests updated
98e818d
@madhurisandbhor
fix: documents api change, deleteMany tags updated, test skipped
f74b03b
@madhurisandbhor
chore: renaming
ca69188
@madhurisandbhor
test: reverting e2e tests for delete action changes
6749b4d
@madhurisandbhor madhurisandbhor self-assigned this Apr 30, 2024
@madhurisandbhor madhurisandbhor added source: core:content-manager Source is core/content-manager package pr: enhancement This PR adds or updates some part of the codebase or features labels Apr 30, 2024
@madhurisandbhor madhurisandbhor changed the title chore(CM): bulk delete and unpublish migration to v5 enhancement(CM): bulk delete and unpublish migration to v5 Apr 30, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 8:27am

@madhurisandbhor madhurisandbhor marked this pull request as ready for review April 30, 2024 11:20
joshuaellis
joshuaellis reviewed May 2, 2024
View reviewed changes
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor polishes, but looks G R E A T

Happy Birthday Bon Anniversaire GIF

packages/core/content-manager/admin/src/pages/ListView/components/BulkActions/Actions.tsx Outdated Show resolved Hide resolved
packages/core/content-manager/admin/src/pages/ListView/components/BulkActions/Actions.tsx Outdated Show resolved Hide resolved
packages/core/content-manager/admin/src/pages/ListView/components/BulkActions/Actions.tsx Show resolved Hide resolved
madhurisandbhor and others added 2 commits May 3, 2024 04:47
@madhurisandbhor @joshuaellis
fix: reverting wrong commit message
52e02eb 
Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
@madhurisandbhor
fix: comments updated
453c50b
@madhurisandbhor madhurisandbhor added the flag: don't merge This PR should not be merged at the moment label May 3, 2024
@madhurisandbhor madhurisandbhor mentioned this pull request May 3, 2024
Open
Base automatically changed from v5/bulk-publish-unpublish to v5/main May 7, 2024 14:59
@Feranchz Feranchz removed the flag: don't merge This PR should not be merged at the moment label May 8, 2024
@Feranchz Feranchz merged commit e1b9d9a into v5/main May 9, 2024
24 of 30 checks passed
@Feranchz Feranchz deleted the fix/bulk-actions-migration branch May 9, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

@Feranchz Feranchz Awaiting requested review from Feranchz

Assignees

@madhurisandbhor madhurisandbhor

Labels
pr: enhancement This PR adds or updates some part of the codebase or features source: core:content-manager Source is core/content-manager package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@madhurisandbhor @joshuaellis @Feranchz