chore(audit-logs): migrate audit logs to v5 #20251
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markkaylor
added
source: core:admin
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
remidej
reviewed
May 2, 2024
packages/core/admin/ee/server/src/services/__tests__/audit-logs.test.ts
Outdated
Show resolved
Hide resolved
Marc-Roig
reviewed
May 8, 2024
Marc-Roig
reviewed
May 8, 2024
| required: true, | ||
| }, | ||
| // @ts-expect-error database model is not yet updated to support useJoinTable | ||
| user: { |
There was a problem hiding this comment.
if this schema is different from v4, we need to create a migration to keep v4 data. I believe all audit-log data will be transfered except the users in this situation.
markkaylor
commented
May 13, 2024
Comment on lines
99
to
100
| const ignoredUids = ['plugin::upload.file', 'plugin::upload.folder']; | ||
| if (ignoredUids.includes(args[0]?.uid)) { |
There was a problem hiding this comment.
@Feranchz do you have any idea what this about? As far as I can tell there isn't anything to ignore from the upload plugin 🤔.
|
Updates:
I think it's ready for another review / QA. You may need to drop your database now that the contentType is back and the model is gone. |
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
How to test it?
Test audit logs are created for the following events