chore!: update styled-components to 6 & update DS to 2.0.0-beta.3

[joshuaellis]

What does it do?

• updates styled-components to v6
• integrates changes from design-system 2.0.0-beta.3

Related issue(s)/PR(s)

• resolves DX-1398
• resolves DX-1253

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
contributor-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 7, 2024 0:43am

[innerdvations]

Mostly just little things.

The only big thing is my concern about requiring everything to be wrapped in Fields with an explicit label, it feels like the increased verbosity will lead to more mistakes and a steeper learning curve. But this isn't my scope so I won't object too strongly 😆

[innerdvations]

There are a ton of unused imports in this file

[joshuaellis]

yeah we can ignore that, @madhurisandbhor is working on re-implementing it all in a different PR.

[innerdvations]

There are a small handful of components that still use ariaLabel instead of aria-label, is that intentional? It feels inconsistent

[joshuaellis]

Depends on the context but most likely yes, we typically pass prop as camelCase and convert to kebab-case. But also, we also have bad naming on some props...

[joshuaellis]

Mostly just little things.

The only big thing is my concern about requiring everything to be wrapped in Fields with an explicit label, it feels like the increased verbosity will lead to more mistakes and a steeper learning curve. But this isn't my scope so I won't object too strongly 😆

Maybe, in an ideal world we'd all just use the form input renderer and we just have one set of fields to maintain, then there is no learning curve.

[innerdvations]

LGTM!

QAd it and only one small issue now, the focus-visible state for text inputs shows the border on the actual inner text input rather than the outer element.

[joshuaellis]

QAd it and only one small issue now, the focus-visible state for text inputs shows the border on the actual inner text input rather than the outer element.

I'll make this a bug in JIRA