Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] SvelteKit tutorial - do not throw redirect #26396

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

ivandotv
Copy link
Contributor

throw redirect is not used in SvelteKit v4 it's just redirect()
In SvelteKit 4 and up, you shouldn't' throw a redirect() rather just call it.

https://kit.svelte.dev/docs/load#redirects

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

docs update

What is the current behavior?

Throwing redirect()
Please link any relevant issues here.

What is the new behavior?

just do redirect()
Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

`throw redirect` is not used in SvelteKit v4 it's just `throw`
Copy link

vercel bot commented May 16, 2024

@ivandotv is attempting to deploy a commit to the Supabase Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@charislam charislam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ivandotv!

@charislam charislam enabled auto-merge (squash) May 22, 2024 01:17
Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ❌ Failed (Inspect) Jun 4, 2024 3:31am
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 3:31am
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 3:31am
zone-www-dot-com ❌ Failed (Inspect) Jun 4, 2024 3:31am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
studio ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 3:31am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 3:31am

@charislam charislam merged commit 1b6a324 into supabase:master Jun 4, 2024
13 of 14 checks passed
encima pushed a commit that referenced this pull request Jun 4, 2024
do not throw redirect

`throw redirect` is not used in SvelteKit v4 it's just `throw`

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants