Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable autocompletion for authorization secrets #9935

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disable autocompletion for authorization secrets #9935

wants to merge 1 commit into from

Conversation

klm-turing
Copy link

Description

This pull request set autoComplete=off to the inputs below so as not to expose the bearer's API key and token by autocompletion when typed.

swagger-ui/src/core/components/auth/api-key-auth.jsx

Lines 73 to 78 in 1367a8f

<Input
id="api_key_value"
type="text"
onChange={ this.onChange }
autoFocus
/>

swagger-ui/src/core/plugins/oas3/components/auth/http-auth.jsx

Lines 132 to 138 in 1367a8f

<Input
id="auth-bearer-value"
type="text"
aria-label="auth-bearer-value"
onChange={ this.onChange }
autoFocus
/>

Motivation and Context

close #9921

How Has This Been Tested?

I opened my browser with localhost:3200 . I clicked on authorize, start typing a secret and closed the modal window.
I reopened the modal window, logged out and started typing a secret again. Autocomplete did not appear.

Screenshots (if appropriate):

Screencast.from.2024-05-13.20-47-19.webm

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable autocompletion for authorization secrets
1 participant
@klm-turing