Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for transition tables #6901

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jamessewell
Copy link

Intial go at adding support for transition tables and relaxing the trigger restrictions on AFTER FOR EACH STATEMENT for hypertables

Seems to work with both INSERT and COPY (copy uses CIM_SINGLE like in the Postgres source).

This still needs testing on other versions (I did 15), and still needs to have some tests written.

fixes #1084

Intial go at adding support for transition tables and relaxing
the trigger restrictions on AFTER FOR EACH STATEMENT for hypertables

Seems to work with both INSERT and COPY (copy uses CIM_SINGLE like in
the Postgres source)
@jamessewell jamessewell self-assigned this May 9, 2024
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix this. Can someone who knows what this does comment pls?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That Assert is weird cause we are checking for the same thing a line below. What is rel here? I'm guessing your rel is not a hypertable and therefore doesn't have fdw_private but might look like a hypertable depending how you look.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably need to modify the relation classification code to treat the transition table not like a normal hypertable.

@svenklemm
Copy link
Member

In the pg source there is explicit comment blocking transition tables for partitioned tables did you investigate the reason for this? I think you might have to do attribute mapping if we decide to allow this. This also needs rebase since PG13 support has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support transition tables in triggers on hypertable
2 participants