Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make constification functions visible outside timescale library #6932

Merged
merged 1 commit into from
May 22, 2024

Conversation

zilder
Copy link
Contributor

@zilder zilder commented May 17, 2024

ts_constify_restrictinfos and ts_constify_restrictinfo_params are useful functions for OSM to implement runtime chunk exclusion. This PR makes them visible from outside the library so that OSM could find and reuse them.

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.72%. Comparing base (59f50f2) to head (01788ca).
Report is 169 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6932      +/-   ##
==========================================
+ Coverage   80.06%   81.72%   +1.65%     
==========================================
  Files         190      198       +8     
  Lines       37181    36851     -330     
  Branches     9450     9637     +187     
==========================================
+ Hits        29770    30117     +347     
+ Misses       2997     2866     -131     
+ Partials     4414     3868     -546     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zilder zilder marked this pull request as ready for review May 21, 2024 14:54
@zilder zilder requested a review from svenklemm May 21, 2024 14:54
@svenklemm svenklemm added this to the TimescaleDB 2.15.1 milestone May 21, 2024
@zilder zilder force-pushed the zilder/extern_constify branch 2 times, most recently from c13d643 to ca0917c Compare May 22, 2024 08:20
Make constification functions available from outside the timescale
library for OSM to use for runtime chunk exclusion.
@zilder zilder enabled auto-merge (rebase) May 22, 2024 08:24
@zilder zilder merged commit 550977d into timescale:main May 22, 2024
35 of 36 checks passed
@pallavisontakke pallavisontakke added the force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug" label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported-2.15.x force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants