Isolate cross-origin IFrames #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to implement this, iframe baseURIs must be recognized. location will still report about:blank, but the base URI or __uv.base will be reliable
WIP window sandboxing
e9x
force-pushed
the
25-iframe-windows-can-easily-be-hijacked
branch
from
5f3fbee
to
4568101
Compare
|
Pro gamer security vulnerability, very nice. Don't know why this hasn't been merged, seems to work. |
|
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
I found this to give issues when doing recaptcha, anyone else the same? |
yea that's the main reason why I've been hesitant to merge this, captchas don't work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will require more thorough testing, but it appears to be effective based on my testing.