Bump Docker images use for documentation to Alpine 3.20 #10695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
changed the title
|
The |
ldez
added
status/2-needs-review
contributor/waiting-for-feedback
and removed
status/0-needs-triage
labels
It does still. I assume the previous version included system installed packages that came with installing pip and/or python3-dev; I've now generated it to have all direct dependencies listed on top and then |
jnoordsij
force-pushed
the
alpine3.19-bump
branch
from
c3d22bf
to
2890a61
Compare
jnoordsij
changed the title
|
Update: bumped to Alpine 3.20, which was released yesterday |
traefiker
force-pushed
the
alpine3.19-bump
branch
from
2890a61
to
0f9d6a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update both Docker images for docs to use the latest Alpine version (3.19).
Given that in Alpine 3.19 Python's package directory is marked as externally managed, the docs image was updated to use a Python venv. The requirements file was updated accordingly, to no longer include unrelated system packages and bump a few (nested) dependencies. Dependency bumps were kept to a minimum, but updating them further might definitely be a good follow-up.
Motivation
While trying to debug docs failure job for #10664, I noticed:
mkdocswere not installable locally usingrequirements.txtThis PR should solve both issues (albeit still not explaining the job failure 馃槗). It should also make Python/pip package installation more consistent, given that system installed packages are no longer used.
More
Additional Notes
Also threw in a typo fix I still had in my diffs because I figured a separate PR would be too much of a thing for this.