Remove duplicate IPAllowList entries #10732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbaptista
changed the title
ldez
added
kind/bug/fix
kevinpollet
changed the title
kevinpollet
requested changes
May 17, 2024
There was a problem hiding this comment.
Hello @davidbaptista and thanks for your contribution,
After trying to reproduce the issue, it appears that the bug only exists with version v3.0. It seems that something went wrong during a merge back.
As we are still supporting the IPWhiteList in v3.0, to fix the issue one of the duplicated IPAllowList UI section in the UI has to be renamed to IPWhiteList.
Please can you make the changes and rebase this pull request to target branch v3.0?
davidbaptista
force-pushed
the
fix_duplicate_ipallowlist
branch
from
47f0b09
to
9a34c69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes duplicate entries for middleware IpAllowList's Source range and IP strategy
Motivation
fixes #10718
More
Additional Notes
No remarks