Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Guava checkNotNull with JDK requireNonNull #222

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Replace Guava checkNotNull with JDK requireNonNull #222

merged 1 commit into from
Jan 26, 2023

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Jan 26, 2023 •
edited

Part of #135

@exoego exoego added the dependencies Pull requests that update a dependency file label Jan 26, 2023
@exoego exoego marked this pull request as ready for review January 26, 2023 04:28
yuokada
yuokada approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@yuokada yuokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

According to the document, https://github.com/google/guava/wiki/PreconditionsExplained,
our use cases don't match with the recommending use cases that continues to use checkNotNull mentioned in it.

@exoego exoego merged commit 11aa98a into master Jan 26, 2023
@exoego exoego deleted the preconditions branch January 26, 2023 13:06
@exoego exoego added chore internal changes (not user-facing) and removed dependencies Pull requests that update a dependency file labels Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuokada yuokada yuokada approved these changes

Assignees
No one assigned
Labels
chore internal changes (not user-facing)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@exoego @yuokada