Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Guava VisibleForTesting #229

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Remove Guava VisibleForTesting #229

merged 2 commits into from
Jan 27, 2023

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Jan 27, 2023 •
edited

Part of #135
Unfortunately, Guava is all-in-one and there is no annotation-only library.

@exoego exoego marked this pull request as ready for review January 27, 2023 04:41
@exoego exoego added the dependencies Pull requests that update a dependency file label Jan 27, 2023
yuokada
yuokada approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@yuokada yuokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@exoego exoego merged commit 5d4c1ee into master Jan 27, 2023
@exoego exoego deleted the VisibleForTesting branch January 27, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuokada yuokada yuokada approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@exoego @yuokada