Guard deprecated platform property #248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to introduce a property to guard
td_platform
value.Currently,
td_platform
is based onwindow.navigator.platform
. However, this property is not recommended now:https://developer.mozilla.org/en-US/docs/Web/API/Navigator/platform
So that I want to introduce a platform property of NavigatorUAData:
window.navigator.userAgentData.platform
.https://developer.mozilla.org/en-US/docs/Web/API/NavigatorUAData/platform
This property changes a value "MacIntel" (M1, M2 Mac is recognized as "MacIntel"!) to "macOS", for example.
However, existing behavior is prioritized because the
window.navigator.userAgentData.platform
has been experimental yet and browser compatibility is so restricted.What do you think about it?