Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new import logs senario #315

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add new import logs senario #315

wants to merge 5 commits into from

Conversation

satoshihirose
Copy link

No description provided.


# How to Run
## Requirement
The workflow requires that Data Landing Areas feature is enabled in your Treasure Data account and thne you've got your User ID to access to it.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo; thne -> then

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will fix.

@@ -0,0 +1,36 @@
# Workflow: Import Treasure Data Logs from Data Landing Area
This example shows how you can use workflow to ingest Treasure Data Logs From Data Landing Areas to your Treasure Data account.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a statement;
"This is Opt-in feature. Contact your Customer Success rep or Technical Support if you have an interest in this feature."

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will fix.

host: ${dla_host}
user: ${user_id}
secret_key_file: {"content": "${secret:sftp.dla_secret_key_file}"}
path_prefix: "/treasure-data-logs/production/${account_id}/workflow_logs/v1/data.csv"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

account id is possibly not unique across regions. Better to use account_key such a 'aws_1' Or 'production' can be production_us, production_tokyo, production_eu01, production_ap02

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understand. Will fix.

host: ${dla_host}
user: ${user_id}
secret_key_file: {"content": "${secret:sftp.dla_secret_key_file}"}
path_prefix: "/treasure-data-logs/${site}/${account_id}/workflow_logs/v1/data.csv"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you block access to the other customer data?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's systematically separated on our Data Landing Areas feature that is using AWS Transfer Family.
So, a customer can only access to the space of the corresponding to the published user_id by TD.
https://treasure-data.atlassian.net/wiki/spaces/EN/pages/1740343892/ERD+Data+Landing+Areas+SFTP
https://docs.aws.amazon.com/ja_jp/transfer/latest/userguide/how-aws-transfer-works.html

Comment on lines 35 to 43
+users:
_env:
TD_API_KEY: ${secret:td.apikey}
py>: script.import_td_users.import_users
database: ${td.database}
table: ${users_table}
api_endpoint: ${api_endpoint}
docker:
image: "digdag/digdag-python:3.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 space

Suggested change
+users:
_env:
TD_API_KEY: ${secret:td.apikey}
py>: script.import_td_users.import_users
database: ${td.database}
table: ${users_table}
api_endpoint: ${api_endpoint}
docker:
image: "digdag/digdag-python:3.9"
+users:
_env:
TD_API_KEY: ${secret:td.apikey}
py>: script.import_td_users.import_users
database: ${td.database}
table: ${users_table}
api_endpoint: ${api_endpoint}
docker:
image: "digdag/digdag-python:3.9"

Copy link
Member

@akito19 akito19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satoshihirose I believe it's ok to merge this PR because @toru-takahashi's change request should have been fixed. (Sorry for the very very very late approval)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants