Add IF EXISTS to DROP ROLE #21985
Open
Add IF EXISTS to DROP ROLE #21985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... in preparation for TestDropRoleTask.
martint
requested changes
May 15, 2024
core/trino-parser/src/main/java/io/trino/sql/tree/DropRole.java
Outdated
Show resolved
Hide resolved
| */ | ||
| @TestInstance(PER_CLASS) | ||
| @Execution(CONCURRENT) | ||
| public class BaseRoleTaskTest |
There was a problem hiding this comment.
Don't use inheritance for this. It makes it harder to maintain the tests, as the subclasses are intimately coupled to the details of the parent. Over time, as some of the tests evolve, the parent becomes a kitchen sink of functionality.
There was a problem hiding this comment.
What would be a good way to factor out the boilerplate and make new tests easy to add? I thought about putting the DropRole tests and SetRole tests into the same class, but I like the regularity of Test<class name>Task naming.
I could, of course, copy-paste the boilerplate into TestDropRoleTask, but that felt unsatisfying.
dekimir
force-pushed
the
drop-role-if-exists
branch
from
5196faf
to
d665624
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add optional
IF EXISTStoDROP ROLE, which suppresses the role-not-found error that you'd otherwise get.Additional context and related issues
Although this option isn't in the ANSI SQL, it's a UX improvement that Trino has traditionally admitted.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: