Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indentation #22018

Merged
merged 1 commit into from
May 20, 2024
Merged

Fix indentation #22018

merged 1 commit into from
May 20, 2024

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented May 18, 2024

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label May 18, 2024
@github-actions github-actions bot added hudi Hudi connector iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector bigquery BigQuery connector mongodb MongoDB connector labels May 18, 2024
wendigo
wendigo approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@wendigo wendigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we enforce that by the checkstyle rule?

@ebyhr
Copy link
Member Author

ebyhr commented May 20, 2024

Hmm, I can't find a way to enforce the rule without affecting other indentations.

@ebyhr ebyhr merged commit a29be29 into trinodb:master May 20, 2024
85 checks passed
@ebyhr ebyhr deleted the ebi/test-indent branch May 20, 2024 01:00
@github-actions github-actions bot added this to the 449 milestone May 20, 2024
@colebow colebow mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wendigo wendigo wendigo approved these changes

Assignees
No one assigned
Labels
bigquery BigQuery connector cla-signed delta-lake Delta Lake connector hive Hive connector hudi Hudi connector iceberg Iceberg connector mongodb MongoDB connector
Milestone
449
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ebyhr @wendigo