feat(db): optimize RocksDB's data backup function #5757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halibobo1205
force-pushed
the
feat/rocksdb_backup_opt
branch
2 times, most recently
from
8265e6b
to
270deef
Compare
halibobo1205
force-pushed
the
feat/rocksdb_backup_opt
branch
from
270deef
to
b0c3854
Compare
| @@ -115,8 +115,7 @@ public synchronized void close() { | |||
| @Override | |||
| public synchronized void reset() { | |||
| head().reset(); | |||
| head().close(); | |||
| head = head.getRoot().newInstance(); | |||
| head = head.getRoot(); | |||
There was a problem hiding this comment.
What is the purpose of the change here?
There was a problem hiding this comment.
Avoid closing databases that need to be backed up:
There was a problem hiding this comment.
could you give more detailed descriptions about this change in the PR? cuz I can not know the reason why should make this change through issue
|
No change plan for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5698.