spidev: process arguments for raw command #2973
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for the raw command, for each arg, dump arg size bytes to stdout. Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
10000TB
approved these changes
May 15, 2024
| if fs.NArg() != 1 { | ||
| return fmt.Errorf("%w: %s <raw|sfdp|id>", errCommand, fs.FlagUsages()) | ||
| if fs.NArg() == 0 { | ||
| return fmt.Errorf("%w: %s <raw [bytes]...|sfdp|id>", errCommand, fs.FlagUsages()) |
There was a problem hiding this comment.
would it make sense to update lin 68 to be consistent with this new format ?
line 68: return fmt.Errorf("%w:<raw|sfdp|id>", errCommand)
There was a problem hiding this comment.
ah, line 80 looks like matching 68, but mis-match with here. does it make sense to use one form to be consistent ?
|
BTW, not related to this change, but |
10000TB
added
Awaiting author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for the raw command, for each arg, dump arg size bytes to stdout.
Ryan, feel free to tell me this should be done differently/better :-)
I just did not want to lose these changes.