Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate AlmaLinux images with a different versioning strategy #1613

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fdr
Copy link
Collaborator

@fdr fdr commented May 17, 2024

This is sort of a revert of
69bf5c8. But it also modifies the versioning to be less specific: AlmaLinux is now requested only by its major version, e.g. "9", not "9.3"

This method is the most like Ubuntu even though it includes one less version number component. Ubuntu has releases like "22.04.3", where we never displayed the last version component. The "3" in AlmaLinux "9.3" is a similar minor version that we don't need to display while remaining consistent with Ubuntu.

That I included the second digit of AlmaLinux before was a mistake I made in the most ancient era: March 2023, whereas the entire code base began in January 2023, adc109d.

@fdr fdr requested a review from pykello May 17, 2024 04:19
@fdr fdr marked this pull request as ready for review May 17, 2024 04:23
Copy link
Member

@enescakir enescakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If an existing customer has the boot image 'almalinux-9.3' when we deploy this PR, we need to update the respective columns.

prog/download_boot_image.rb Outdated Show resolved Hide resolved
@fdr fdr force-pushed the almalinux-again branch 3 times, most recently from 367906a to 4129e1a Compare May 21, 2024 00:59
@fdr
Copy link
Collaborator Author

fdr commented May 21, 2024

If an existing customer has the boot image 'almalinux-9.3' when we deploy this PR, we need to update the respective columns.

good catch.

arch = (vm_host.arch == "x64") ? "x86_64" : "aarch64"
"https://vault.almalinux.org/9.3/cloud/#{arch}/images/AlmaLinux-9-GenericCloud-9.3-#{version}.#{arch}.qcow2"
"https://repo.almalinux.org/almalinux/9/cloud/#{arch}/images/AlmaLinux-9-GenericCloud-#{version}.#{arch}.qcow2"
Copy link
Contributor

@pykello pykello May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They delete old images from https://repo.almaunix.org/, so this will give 404 after a while. Not sure if this is okay or not. However, they keep the images in https://vault.almalinux.org/ for longer.

E.g., 9.2 and before have been dropped from repo at the moment, but they are still available at vault, although probably not easy to get a formula for this based on only release date.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll ask about it. 9.4 is not available at vault even though it is available at repo. https://chat.almalinux.org/almalinux/pl/csdgnxhr37g7xmo1qkiu69nktc

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like new versions are not in vault. I complained a bit about this making permalinks difficult, but between "lagging a version behind" and "need to figure out something to deal with this archiving problem," perhaps we should do "need to figure something out" (or change links to vault as they age out)

@pykello
Copy link
Contributor

pykello commented May 21, 2024

If an existing customer has the boot image 'almalinux-9.3' when we deploy this PR, we need to update the respective columns.

I am not sure if I understand this comment correctly. But note that the path in the rhizome side is a function of the name, and is important when operations like removing the image.

@fdr
Copy link
Collaborator Author

fdr commented May 21, 2024

If an existing customer has the boot image 'almalinux-9.3' when we deploy this PR, we need to update the respective columns.

I am not sure if I understand this comment correctly. But note that the path in the rhizome side is a function of the name, and is important when operations like removing the image.

if we have existing AlmaLinux VMs, the boot_image field may need a change, it's currently like almalinux-9.3. Granted, we've been somewhat fast and loose here, including removing support altogether, given that it sees little use and was even broken at one time.

Do you see a problem with this conflicting with legacy VMs that pre-date BootImage? Did you do some kind of backport that will be broken by it?

@pykello
Copy link
Contributor

pykello commented May 21, 2024

Do you see a problem with this conflicting with legacy VMs that pre-date BootImage? Did you do some kind of backport that will be broken by it?

Updating Vm.boot_image is ok. So, go ahead with that.

I was more concerned with updating BootImage.name fields. Note that we also created BootImage records for legacy almalinux installations & updated legacy VM storage volumes to point to them. Updating BootImage.name for legacy almalinux-9.3 needs more care, as BootImage.name determines the image path.

@fdr fdr force-pushed the almalinux-again branch 2 times, most recently from 170e4b7 to d2dad42 Compare May 31, 2024 21:46
This is partially a revert of
69bf5c8. But it also modifies the
versioning to be less specific: AlmaLinux is now requested only by its
major version, e.g. "9", not "9.3". It also adds almalinux-8, for
which we have some demand, and as it has similar looking URLs and
considerations I thought to include it.

This method is the most like Ubuntu even though it includes one less
version number component.  Ubuntu has releases like "22.04.3", where
we never displayed the last version component.  The "3" in AlmaLinux
"9.3" is a similar minor version that we don't need to display while
remaining consistent with Ubuntu.

That I included the second digit of AlmaLinux before was a mistake I
made in the most ancient era: March 2023, whereas the entire code base
began in January 2023, adc109d.
@fdr
Copy link
Collaborator Author

fdr commented May 31, 2024

If an existing customer has the boot image 'almalinux-9.3' when we deploy this PR, we need to update the respective columns.

...hmm, well, maybe we should, but do we? aren't they busted right now, where there's no support? what does that accomplish? actually, we're a bit fuzzy on what the column on Vm does now that BootImage also exists and there's a foreign key to it via storage volumes.

After images have been downloaded onto some or all hosts, this patch
permits showing these choices to the user.
@fdr fdr force-pushed the almalinux-again branch 2 times, most recently from 5cd7923 to 5b6c7eb Compare May 31, 2024 22:17
@fdr fdr requested review from pykello and enescakir May 31, 2024 22:18
@fdr
Copy link
Collaborator Author

fdr commented May 31, 2024

Requesting re-review, I didn't change a whole lot, but added almalinux-8 and phased the patches for deploy

@enescakir
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants