Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: JS close flash message error #1414 #1432

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Fix: JS close flash message error #1414 #1432

merged 3 commits into from
Apr 23, 2024

Conversation

verheyenkoen
Copy link
Contributor

Fixes JavaScript error when dismissing flash messages manually, reported in #1414.

The fix for this (commit a0733a8) can be reverted if the issue gets fixed in HTMX (bigskysoftware/htmx#2497).

@verheyenkoen verheyenkoen added bug Something isn't working cypress-tested labels Apr 19, 2024
@verheyenkoen verheyenkoen requested a review from nics April 19, 2024 12:30
@verheyenkoen verheyenkoen self-assigned this Apr 19, 2024
@nics nics merged commit a77ed0c into dev Apr 23, 2024
1 of 2 checks passed
@nics nics deleted the fix/js-close-toast-error branch April 23, 2024 12:15
@verheyenkoen verheyenkoen linked an issue Apr 23, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cypress-tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS error when closing toast
2 participants