fix: object overwriting when using multiple charts #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BitTheByte thank your very much for PR. Would you mind to provide use-case how I can replicate the issue in the screenshot above? I want to test the functionality but I'm not sure where to start. |
|
I was not able to replicate the issue. If you find a time to write proper detailed description how to reproduce, please open new issue linking this PR and I will take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an overwrite bug in the
DEFAULT_CHART_OPTIONSas it was shared and mutated between chart instances resulting in a wrong rendering.Before:
After:
