Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add site favicon to skeleton.html #382

Closed
wants to merge 1 commit into from

Conversation

furkankurt
Copy link

Django Unfold doesn't have a favicon feature.
We had to override the whole skeleton.html template to add a favicon. (#206)

I have added a site_favicon.html file to the unfold/helpers directory, we can add all favicon types to the website.
Instead of overriding the skeleton.html, we will override just the site_favicon.html.

PS: I added example favicon links as template comments.

@frobert
Copy link

frobert commented May 15, 2024

I would suggest you also add option to change the favicon in settings.py UNFOLD config the same way as SITE_ICON, ex.

"FAVICON": { 
  "light": lambda request: static("favicon.png"),
  "dark": lambda request: static("favicon_dark.png"),
}

@lukasvinclav
Copy link
Contributor

Hey, thanks for good initial PR. Would you mind to create an issue for this task? Don't forget to link this PR there.

@furkankurt
Copy link
Author

Hey, thanks for good initial PR. Would you mind to create an issue for this task? Don't forget to link this PR there.

Hello, thank you for your valuable comment. I've created an issue about this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants