Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug : footer-line break issue #695

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

wooseok123
Copy link

@wooseok123 wooseok123 commented Apr 17, 2023

debug footer line break issue

issue : #694

changes :

margin-left of dark-mode-toggle : 1em to 0.15em
font-size of nav : 16px to 15px

I've changed margin-left value of dark-mode-toggle to 0.15em and font-size of anchor tag in #footer nav to 15px so that the letter 'light' and 'dark' can be in the same line until 819px.

The layout changes when the width is under 818px. So i think it would be better if there's no line break until 819px.
So it works on my code!

Before

(over 860px)
image
image

After

(over 860px, it maintains the same line until 819px)
image
image

@wooseok123 wooseok123 changed the title chore : change margin-left value debug : footer-line break issue Apr 17, 2023
@@ -224,6 +224,10 @@ hr {
align-items: flex-end;
}

#footer nav {
font-size : 15px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not adding a new font-size.
How about removing the dots . separators between the nav links and add margin-right: 0.5em for footer nav a?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your opinion.
I've just added the modified version. (removing dots and adding margin-right to them, and things i had to do to align them in the right position.)

The line-break still remains in the mobile version, but i think it's not a big deal.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And how about adding .prettierrc at the root of the project?
I've reset the initial commit because my local prettier settings had activated.

Copy link
Contributor

@camillobruni camillobruni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (let's add the prettierc in a separate PR)

@wooseok123
Copy link
Author

LGTM (let's add the prettierc in a separate PR)

Thanks! I'll open another PR about formatting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants