Fix Ninja Schema Typing #1165
Merged
Fix Ninja Schema Typing #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-muoto
force-pushed
the
fix-ninja-schema-typing
branch
from
e259a73
to
a1e047c
Compare
max-muoto
commented
May 15, 2024
| @@ -29,6 +37,7 @@ def resolve_name(obj): | |||
| from pydantic._internal._model_construction import ModelMetaclass | |||
| from pydantic.functional_validators import ModelWrapValidatorHandler | |||
| from pydantic.json_schema import GenerateJsonSchema, JsonSchemaValue | |||
| from typing_extensions import dataclass_transform | |||
There was a problem hiding this comment.
Until the minimum is 3.11, we'll have to import from typing extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Ninja schema typing by adding a dataclass transformer, as specified in PEP 681. This transformer matches that of Pydantic's model metaclass.
Now, instead of Ninja schemas being typed as
**kwargs: Any, one will get static type-checking on each field.Fixes: #1094, #1050, #1053
Example: