Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-core): should set <math> tag as block to retain MathML namespace after patching #10891

Merged
merged 3 commits into from
May 28, 2024
Merged

fix(compiler-core): should set <math> tag as block to retain MathML namespace after patching #10891

merged 3 commits into from
May 28, 2024

Conversation

linzhe141
Copy link
Contributor

close #10855

@linzhe141 linzhe141 changed the title fix(runtime-dom): due to dynamicChildren, fix the bug that the element of mathml cannot be created normally. fix(compiler-core): math tag should use block May 9, 2024
@linzhe141 linzhe141 force-pushed the fix-mathml-tag branch 2 times, most recently from 178b2a1 to 6b9f3b7 Compare May 9, 2024 06:24
@edison1105 edison1105 added 🐞 bug Something isn't working ready for review This PR requires more reviews labels May 11, 2024
@linzhe141 linzhe141 requested a review from edison1105 May 12, 2024 00:03
@sodatea sodatea added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label May 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 15, 2024 •
edited

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.7 kB 34.5 kB 31.1 kB
vue.global.prod.js 148 kB (+28 B) 53.7 kB (+8 B) 48 kB (-35 B)

Usages

Name Size Gzip Brotli
createApp 50.8 kB 19.9 kB 18.1 kB
createSSRApp 54.1 kB 21.2 kB 19.3 kB
defineCustomElement 53.1 kB 20.6 kB 18.8 kB
overall 64.5 kB 24.9 kB 22.6 kB

@sodatea sodatea added ready to merge The PR is ready to be merged. and removed ready for review This PR requires more reviews labels May 15, 2024
sodatea
sodatea requested changes May 20, 2024
View reviewed changes
Copy link
Member

@sodatea sodatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should update

core/packages/compiler-core/src/transforms/hoistStatic.ts

Lines 174 to 179 in fd18ce7

if (
codegenNode.isBlock &&
node.tag !== 'svg' &&
node.tag !== 'foreignObject'
) {
return ConstantTypes.NOT_CONSTANT
too

Otherwise the hoistStatic transform won't behave correctly for math blocks:
https://deploy-preview-10891--vue-sfc-playground.netlify.app/#eNp9Uk1v1DAQ/SvGlwXRrukHlyqNBKgScAAESFx8Ccls1q2/ZE/SVFH+e8dOdptKVS9R3nszz8/jGfkn77d9B/yKF7EOyiOLgJ0vpVXGu4BsZAF2bGK74AzbUOlGWmlrZyMyE1t2nfS3m6+gtWP/XNDNm807aQsx25ERAQTjdYVAiLFif1aOY26epkIQyqyyvkPWnxrXgL6WnHTJmcgGJJsK96xRkXweSP2vXX1HumoIwAfJZ5MIprKo6rgIZ4uQDIK7X9jzI5v4mK87o4RVORSCvmvOlufE2acu8aytMK58T5xbMap8WNnQL51/AJW1DitUzp4ORjOgeTbKtpQNYUCxR6OPd7tYh21Uv9CXy3AWIfbtInxcCYV4ftI8JHGcEmEKRpOdn0ms3omfcIz0zDvVbm+js7QhY+qWvHbGKw3hp0+2UfIrlpWkVbQF998zh6GDkwNf76G+e4G/jUPiJP8VIELoQfKjhlVoAWf55s8PGsxKpC3pNFW/Iv6G6HSXMs5lnzvbUOxVXU77Le85Tf9vvBkQbDxcKgVNlVOul5x2/8srV3+Ke7G9zH3STnx6BLxXEag=

@sodatea sodatea removed the ready to merge The PR is ready to be merged. label May 20, 2024
@linzhe141 linzhe141 requested a review from sodatea May 21, 2024 01:59
@sodatea sodatea added the ready for review This PR requires more reviews label May 21, 2024
@sodatea sodatea changed the title fix(compiler-core): math tag should use block fix(compiler-core): should set <math> tag as block to retain MathML namespace after patching May 21, 2024
@linzhe141 linzhe141 requested a review from edison1105 May 28, 2024 01:37
@sodatea sodatea added ready to merge The PR is ready to be merged. ready for review This PR requires more reviews and removed ready for review This PR requires more reviews labels May 28, 2024
@sodatea sodatea merged commit 87c5443 into vuejs:main May 28, 2024
11 checks passed
@linzhe141 linzhe141 deleted the fix-mathml-tag branch May 28, 2024 06:27
wangdaoo pushed a commit to wangdaoo/core that referenced this pull request May 30, 2024
@linzhe141 @wangdaoo
fix(compiler-core): should set <math> tag as block to retain MathML…
ad0ab29 
… namespace after patching (vuejs#10891)

Co-authored-by: linzhe141 <linzhe141@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sodatea sodatea sodatea approved these changes

@edison1105 edison1105 edison1105 approved these changes

@baiwusanyu-c baiwusanyu-c baiwusanyu-c approved these changes

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working ready to merge The PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with MathML support
4 participants
@linzhe141 @sodatea @edison1105 @baiwusanyu-c