Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't output coverage results to stdout #7153

Merged
merged 1 commit into from
May 22, 2024

Conversation

sethidden
Copy link
Contributor

@sethidden sethidden commented May 14, 2024

Change the default value of coverageReporters from ["clover", "json", "lcov", "text"] to not include "text"

https://jestjs.io/docs/configuration#coveragereporters-arraystring--string-options

Change the default value of coverageReporters from ["clover", "json",
"lcov", "text"] to not include "text"

https://jestjs.io/docs/configuration#coveragereporters-arraystring--string-options
@sethidden sethidden requested a review from a team as a code owner May 14, 2024 11:33
Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: cda88f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vue-storefront/jest-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

},
coverageDirectory: "./coverage/",
collectCoverageFrom: ["src/**/*.ts"],
coverageRepoters: ["clover", "json", "lcov" /* "text" */],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this text?

Copy link
Contributor Author

@sethidden sethidden May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text outputs to stdout, we don't want that as it clutters the output in ci, we upload the coverage to sonarcloud anyway

@sethidden sethidden merged commit ce14a81 into main May 22, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants