-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: sdk 2.0.0 #7156
base: main
Are you sure you want to change the base?
docs: sdk 2.0.0 #7156
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, but looks great overall
@@ -81,6 +86,8 @@ Let's break down the code above: | |||
|
|||
- The `middlewareModule` is an SDK module that ensures communication with the Server Middleware. It takes the `UnifiedEndpoints` type as a generic parameter. The `UnifiedEndpoints` type is a type that represents the endpoints of the Server Middleware. | |||
|
|||
- The `defaults` is the default configuration of the SDK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also explain cdnCacheBustingId
? Based on the next doc it seems like it's autogenerated during CI/CD? But it would be nice to explain what it is, why it's needed, and where the value comes from,
Also, how does someone use the defaults
object? Is it always going to bedefaults.unifiedCommerce.middlewareModule.defaultMethodsRequestConfig
or how does someone know which values to access
π Linked issue
β Type of change
π Description
π Checklist