Add Loki target #657
Open
Add Loki target #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Loki targets require the
"datasource": {"type": "loki", "uid": "[...]"}field split in order to work in Grafana – as tested in Grafana Cloud which would give me cryptic error messages otherwise.Why is it a good idea?
Loki is a great way to quickly put together custom dashboards if only (parseable) logs are available for an application, but not metrics. There was no previous example how to use
grafanalibfor Loki queries.Questions
I added a basic test. Not sure if I should add an example or more documentation.
Also, I made the
LokiTargeta standalone class, not based onTarget, since the "base fields" inTargetare not desired (e.g. adding the fieldqueryor others could lead to errors, I think).