Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dot graviton sve #4797

Merged
merged 8 commits into from
Jun 6, 2024
Merged

Dot graviton sve #4797

merged 8 commits into from
Jun 6, 2024

Conversation

ajit283
Copy link
Contributor

@ajit283 ajit283 commented Apr 29, 2024

What's being changed:

Add dot product graviton sve simd implementation

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
32.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ajit283
Copy link
Contributor Author

ajit283 commented Jun 5, 2024

Benchmark:

goos: linux
goarch: arm64
pkg: github.com/weaviate/weaviate/adapters/repos/db/vector/hnsw/distancer
                      │ pure_go.txt  │              sve.txt               │
                      │    sec/op    │   sec/op     vs base               │
Dot/30_dimensions-2      12.72n ± 2%   12.77n ± 0%        ~ (p=0.097 n=6)
Dot/32_dimensions-2      13.49n ± 0%   10.51n ± 0%  -22.12% (p=0.002 n=6)
Dot/128_dimensions-2     50.86n ± 0%   19.12n ± 0%  -62.40% (p=0.002 n=6)
Dot/256_dimensions-2    100.25n ± 0%   34.16n ± 0%  -65.93% (p=0.002 n=6)
Dot/300_dimensions-2    117.25n ± 0%   43.80n ± 0%  -62.65% (p=0.002 n=6)
Dot/384_dimensions-2    149.60n ± 0%   49.06n ± 0%  -67.20% (p=0.002 n=6)
Dot/600_dimensions-2    236.60n ± 0%   70.66n ± 0%  -70.14% (p=0.002 n=6)
Dot/768_dimensions-2    301.45n ± 0%   87.61n ± 0%  -70.94% (p=0.002 n=6)
Dot/1024_dimensions-2    400.0n ± 0%   113.9n ± 0%  -71.52% (p=0.002 n=6)
Dot/1536_dimensions-2    597.4n ± 0%   167.0n ± 0%  -72.05% (p=0.002 n=6)
geomean                  110.1n        43.11n       -60.84%

Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
20.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Member

@asdine asdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

@asdine asdine merged commit ca98c2b into main Jun 6, 2024
40 of 42 checks passed
@asdine asdine deleted the dot_graviton_sve branch June 6, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants