Fix list jobs and intervals mismatch #3767
Conversation
Fix a mismatch between to endpoints when filtering by concurrency key
Deploying windmill with 聽
|
| Latest commit: |
4dd50a0
|
| Status: | 鈿★笍聽 Build in progress... |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
馃憤 Looks good to me! Reviewed everything up to fb0a6c7 in 4 minutes and 18 seconds
More details
- Looked at
1107lines of code in7files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_dOyg2PeMQseZ8TnX
You can customize Ellipsis with 馃憤 / 馃憥 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
馃憤 Looks good to me! Reviewed everything up to 7ca08be in 3 minutes and 45 seconds
More details
- Looked at
1171lines of code in7files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_MRLO2sOnUkRvgq8s
You can customize Ellipsis with 馃憤 / 馃憥 feedback, review rules, user-specific overrides, quiet mode, and more.
| )); | ||
| } | ||
|
|
||
| const QJ_FIELDS: &[&str] = &[ |
There was a problem hiding this comment.
is that different from the ones of list_jobs ? Can we make it a common const if yes
There was a problem hiding this comment.
馃憤 Looks good to me! Incremental review on c11e1a2 in 4 minutes and 41 seconds
More details
- Looked at
45lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. backend/windmill-api/src/concurrency_groups.rs:394
- Draft comment:
Consider renamingget_concurrent_intervalstoget_concurrent_jobsto align with the new endpoint naming convention (/list_jobs). This will improve consistency and readability. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_O0Srw3q5Ci5LBgE7
You can customize Ellipsis with 馃憤 / 馃憥 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
馃憤 Looks good to me! Incremental review on 6b08034 in 2 minutes and 38 seconds
More details
- Looked at
193lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. backend/windmill-api/src/jobs.rs:936
- Draft comment:
The functionfilter_list_queue_queryis quite complex and handles many different conditions for filtering SQL queries. Consider refactoring this function to improve readability and maintainability. Breaking it down into smaller, more focused functions could help manage complexity, especially as new filters might be added in the future. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_Rp1ZBtfbtMttM7b6
You can customize Ellipsis with 馃憤 / 馃憥 feedback, review rules, user-specific overrides, quiet mode, and more.
Summary:
Refactored job listing and concurrency handling in the backend and updated frontend components to use the new API structure.
Key points:
/intervalsendpoint to/list_jobsinconcurrency_groups.rs.openapi.yamlto reflect new endpoint and data structures.concurrency_groups.rsfor new endpoint and data handling.ConcurrentJobsChart.svelte,JobLoader.svelte, andRunsTable.svelteto use updated API.Generated with 鉂わ笍 by ellipsis.dev
Summary:
Refactored job listing and concurrency handling in the backend and updated frontend components to use the new API structure, with enhanced data privacy features and improved efficiency.
Key points:
get_concurrent_intervalsinconcurrency_groups.rsto handle job listings with concurrency keys and user permissions./concurrency_groups.rsand/jobs.rs.Generated with 鉂わ笍 by ellipsis.dev