Support deprecating Web Vitals table #11096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dedabbc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
ematipico
approved these changes
May 20, 2024
| @@ -2,7 +2,8 @@ import { defineDbIntegration } from '@astrojs/db/utils'; | |||
| import { AstroError } from 'astro/errors'; | |||
| import { WEB_VITALS_ENDPOINT_PATH } from './constants.js'; | |||
|
|
|||
| export default function webVitals() { | |||
| export default function webVitals({ deprecated }: { deprecated?: boolean } = {}) { | |||
| process.env.DEPRECATE_WEB_VITALS = deprecated ? 'true' : undefined; | |||
There was a problem hiding this comment.
Shouldn't we set this only when running a db push? Or is it intentional?
There was a problem hiding this comment.
I guess you might want it in dev etc. too? If you happened to run it while deprecated. Probably doesn’t matter either way though — I just wanted it to match how a user-defined table might behave really.
matthewp
approved these changes
May 20, 2024
sarah11918
approved these changes
May 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
deprecated: trueon a table and push that before it will allow you to remove it completely. Because integrations control the tables themselves this is not something users can do themselves, so this PR reflects that up to the integration options.Testing
Tested manually that the
deprecatedproperty is being set properly on the table config.Docs
/cc @withastro/maintainers-docs for feedback on the README changes!