Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CYS Full Composability] Ensure that the assembler doesn't crash when the feature flag is enabled, but the site doesn't have the latest version of Gutenberg. #47546

Merged
merged 28 commits into from
May 28, 2024
Merged

[CYS Full Composability] Ensure that the assembler doesn't crash when the feature flag is enabled, but the site doesn't have the latest version of Gutenberg. #47546

merged 28 commits into from
May 28, 2024

Conversation

gigitux
Copy link
Contributor

@gigitux gigitux commented May 16, 2024 •
edited

Warning

This PR is blocked by #47415

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #47545.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Ensure that you don't have Gutenberg enabled.
  2. Make sure you have the WooCommerce beta tester plugin installed
  3. Head over to Tools > WCA Test Helper > Features
  4. Make sure you see the pattern-toolkit-full-composability on the list.
  5. Enable it.
  6. Head over to WooCommerce > Home > Customize your store.
  7. Ensure that the Assembler doesn't crash.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

[CYS Full Composability] Ensure that the assembler doesn't crash when the feature flag is enabled, but the site doesn't have the latest version of Gutenberg.

Comment

gigitux and others added 25 commits May 9, 2024 16:19
@gigitux
CYS: allow to the user to move the pattern
4350a79
@gigitux
add feature flag
e898dee
@gigitux
Merge branch 'trunk' of github.com:woocommerce/woocommerce into poc/m…
2c21ef8 
…ove-patterns
@gigitux
Merge branch 'trunk' of github.com:woocommerce/woocommerce into poc/m…
5482045 
…ove-patterns
@gigitux
Merge branch 'trunk' of github.com:woocommerce/woocommerce into poc/m…
f5b77a4 
…ove-patterns
Add changefile(s) from automation for the following project(s): wooco…
f641676 
…mmerce
@gigitux
CYS: Add shuffle button
8437f1a
@gigitux
CYS - add shuffle feature
ca31d29
Add changefile(s) from automation for the following project(s): wooco…
393c2d0 
…mmerce
@gigitux
Merge branch 'trunk' of github.com:woocommerce/woocommerce into poc/m…
d34a17c 
…ove-patterns
@gigitux
use WooCommerce feature flag approach
f58d81c
@gigitux
Merge branch 'poc/move-patterns' of github.com:woocommerce/woocommerc…
bc104af 
…e into poc/move-patterns
@gigitux
Merge branch 'poc/move-patterns' of github.com:woocommerce/woocommerc…
a15e540 
…e into poc/shuffle
@gigitux
Merge branch 'poc/shuffle' of github.com:woocommerce/woocommerce into…
ef93a08 
… poc/shuffle
@gigitux
fix lint error
ecab80f
@gigitux
Merge branch 'trunk' of github.com:woocommerce/woocommerce into poc/m…
d13e80b 
…ove-patterns
@gigitux
Merge branch 'poc/move-patterns' of github.com:woocommerce/woocommerc…
c202a4b 
…e into poc/shuffle
@gigitux
Merge branch 'trunk' of github.com:woocommerce/woocommerce into poc/m…
db9567d 
…ove-patterns
@gigitux
Merge branch 'poc/move-patterns' of github.com:woocommerce/woocommerc…
9404038 
…e into poc/shuffle
@gigitux
Merge branch 'trunk' of github.com:woocommerce/woocommerce into poc/m…
ca0276b 
…ove-patterns
@gigitux
Merge branch 'poc/move-patterns' of github.com:woocommerce/woocommerc…
460692e 
…e into poc/shuffle
@gigitux
Highlight the pattern when the user hovers it
cca31df
Add changefile(s) from automation for the following project(s): wooco…
1b102fc 
…mmerce
@gigitux
Merge branch 'add/highlight-selected-block' of github.com:woocommerce…
bf37260 
…/woocommerce into 47545-cys-full-composability-ensure-that-the-assembler-doesnt-crash-when-the-feature-flag-is-enabled-but-site-doesnt-have-the-latest-version-of-gutenberg
@gigitux
CYS - Assembler: improve feature flag check
cb6ac99
@gigitux gigitux added type: bug The issue is a confirmed bug. focus: customize-your-store Issues related to the Customize Your Store onboarding flow. labels May 16, 2024
@gigitux gigitux requested review from albarin and nefeline May 16, 2024 12:18
@gigitux gigitux self-assigned this May 16, 2024
@gigitux gigitux linked an issue May 16, 2024 that may be closed by this pull request
[CYS - Full Composability] Ensure that the Assembler doesn't crash when the feature flag is enabled, but site doesn't have the latest version of Gutenberg #47545
Closed
@woocommercebot woocommercebot requested a review from a team May 16, 2024 12:18
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label May 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited

Hi @albarin, @nefeline, @woocommerce/woo-fse

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@gigitux gigitux changed the base branch from trunk to add/highlight-selected-block May 16, 2024 12:19
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

albarin
albarin approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@albarin albarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

nefeline
nefeline approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@nefeline nefeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @gigitux ! Confirmed everything works as described: nice idea adding the isFullComposabilityFeatureAndAPIAvailable constant :)

@gigitux
Copy link
Contributor Author

gigitux commented May 17, 2024

Thanks for the review! Re-checking the code, I noticed an error that I fixed with 8db65a1

Checking the length of the array doesn't guarantee that all the APIs we will put in it are defined.

Base automatically changed from add/highlight-selected-block to trunk May 28, 2024 08:16
@gigitux
Merge branch 'trunk' of github.com:woocommerce/woocommerce into 47545…
6a6f62e 
…-cys-full-composability-ensure-that-the-assembler-doesnt-crash-when-the-feature-flag-is-enabled-but-site-doesnt-have-the-latest-version-of-gutenberg
@gigitux gigitux enabled auto-merge (squash) May 28, 2024 08:17
@gigitux gigitux merged commit 72d7a8b into trunk May 28, 2024
26 checks passed
@gigitux gigitux deleted the 47545-cys-full-composability-ensure-that-the-assembler-doesnt-crash-when-the-feature-flag-is-enabled-but-site-doesnt-have-the-latest-version-of-gutenberg branch May 28, 2024 08:40
@github-actions github-actions bot added this to the 9.1.0 milestone May 28, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label May 28, 2024
samueljseay pushed a commit that referenced this pull request May 28, 2024
@gigitux @samueljseay
[CYS Full Composability] Ensure that the assembler doesn't crash when…
c8a5f31 
… the feature flag is enabled, but the site doesn't have the latest version of Gutenberg. (#47546)

* CYS: allow to the user to move the pattern

* add feature flag

* Add changefile(s) from automation for the following project(s): woocommerce

* CYS: Add shuffle button

* CYS - add shuffle feature

* Add changefile(s) from automation for the following project(s): woocommerce

* use WooCommerce feature flag approach

* fix lint error

* Highlight the pattern when the user hovers it

* Add changefile(s) from automation for the following project(s): woocommerce

* CYS - Assembler: improve feature flag check

* Add changefile(s) from automation for the following project(s): woocommerce

* improve logic

---------

Co-authored-by: github-actions <github-actions@github.com>
@Stojdza Stojdza added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albarin albarin albarin approved these changes

@nefeline nefeline nefeline approved these changes

Assignees

@gigitux gigitux

Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
9.1.0
4 participants
@gigitux @albarin @nefeline @Stojdza