-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CYS Full Composability] Ensure that the assembler doesn't crash when the feature flag is enabled, but the site doesn't have the latest version of Gutenberg. #47546
[CYS Full Composability] Ensure that the assembler doesn't crash when the feature flag is enabled, but the site doesn't have the latest version of Gutenberg. #47546
Conversation
…e into poc/move-patterns
…e into poc/shuffle
…e into poc/shuffle
…e into poc/shuffle
…e into poc/shuffle
…/woocommerce into 47545-cys-full-composability-ensure-that-the-assembler-doesnt-crash-when-the-feature-flag-is-enabled-but-site-doesnt-have-the-latest-version-of-gutenberg
Hi @albarin, @nefeline, @woocommerce/woo-fse Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work @gigitux ! Confirmed everything works as described: nice idea adding the isFullComposabilityFeatureAndAPIAvailable
constant :)
Thanks for the review! Re-checking the code, I noticed an error that I fixed with 8db65a1 Checking the length of the array doesn't guarantee that all the APIs we will put in it are defined. |
…-cys-full-composability-ensure-that-the-assembler-doesnt-crash-when-the-feature-flag-is-enabled-but-site-doesnt-have-the-latest-version-of-gutenberg
… the feature flag is enabled, but the site doesn't have the latest version of Gutenberg. (#47546) * CYS: allow to the user to move the pattern * add feature flag * Add changefile(s) from automation for the following project(s): woocommerce * CYS: Add shuffle button * CYS - add shuffle feature * Add changefile(s) from automation for the following project(s): woocommerce * use WooCommerce feature flag approach * fix lint error * Highlight the pattern when the user hovers it * Add changefile(s) from automation for the following project(s): woocommerce * CYS - Assembler: improve feature flag check * Add changefile(s) from automation for the following project(s): woocommerce * improve logic --------- Co-authored-by: github-actions <github-actions@github.com>
Warning
This PR is blocked by #47415
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #47545.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
pattern-toolkit-full-composability
on the list.Changelog entry
Significance
Type
Message
[CYS Full Composability] Ensure that the assembler doesn't crash when the feature flag is enabled, but the site doesn't have the latest version of Gutenberg.
Comment